[pigment][next] Warn about unsupported turbo mode in Next.js #41445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brijeshb42
commented
Mar 11, 2024
brijeshb42
commented
- I have followed (at least) the PR section of the contributing guide.
Netlify deploy previewhttps://deploy-preview-41445--material-ui.netlify.app/ Bundle size report |
brijeshb42
force-pushed
the
pigment/next-turbo-warn
branch
2 times, most recently
from
424a97a to
10230f9
Compare
samuelsycamore
changed the title
github-actions
bot
added
the
PR: out-of-date
brijeshb42
force-pushed
the
pigment/next-turbo-warn
branch
from
10230f9 to
12c84ae
Compare
github-actions
bot
removed
the
PR: out-of-date
brijeshb42
requested review from
siriwatknp
and removed request for
mnajdova and
siriwatknp
siriwatknp
reviewed
Mar 13, 2024
| const { babelOptions, asyncResolve, ...rest } = pigmentConfig; | ||
| export function withPigment(nextConfig: NextConfig, pigmentConfig?: PigmentOptions) { | ||
| const { babelOptions = {}, asyncResolve, ...rest } = pigmentConfig ?? {}; | ||
| if (process.env.TURBOPACK === '1') { |
There was a problem hiding this comment.
Is there a link to where TURBOPACK is coming from? Would be nice to have a comment about this.
There was a problem hiding this comment.
It's undocumented. I had to go through next.js code to find it.
siriwatknp
approved these changes
Mar 13, 2024
This was referenced May 19, 2024
This was referenced May 20, 2024
This was referenced May 21, 2024
This was referenced Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.