Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pigment-css] Fix component selector, use class selector instead of class value #41442

Merged
merged 1 commit into from
Mar 11, 2024
Merged

[pigment-css] Fix component selector, use class selector instead of class value #41442

merged 1 commit into from
Mar 11, 2024

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Mar 10, 2024 •
edited
Loading

for composition. Now, you don't have to explicitly add a "." selector.

Fixes #41421

@brijeshb42
[pigment-css][react] Use class selector instead of value
eb362dd 
for composition. Now, you don't have to explicitly add a "." selector.
@brijeshb42 brijeshb42 added the package: pigment-css Specific to @pigment-css/* label Mar 10, 2024
@mui-bot
Copy link

mui-bot commented Mar 10, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41442--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against eb362dd

@brijeshb42 brijeshb42 changed the title [pigment-css][react] Use class selector instead of value [pigment-css][react] Use class selector instead of class value Mar 10, 2024
@brijeshb42 brijeshb42 requested a review from siriwatknp March 11, 2024 04:02
siriwatknp
siriwatknp approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 it is consistent with emotion/styled-components.

@brijeshb42 brijeshb42 merged commit 13d4a67 into mui:master Mar 11, 2024
20 checks passed
@brijeshb42 brijeshb42 deleted the pigment/composition branch March 11, 2024 07:39
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Mar 11, 2024
@oliviertassinari oliviertassinari changed the title [pigment-css][react] Use class selector instead of class value [pigment-css] Use class selector instead of class value Mar 11, 2024
@oliviertassinari oliviertassinari changed the title [pigment-css] Use class selector instead of class value [pigment-css] Fix component selector API, use class selector instead of class value Mar 11, 2024
@oliviertassinari oliviertassinari changed the title [pigment-css] Fix component selector API, use class selector instead of class value [pigment-css] Fix component selector, use class selector instead of class value Mar 11, 2024
This was referenced May 19, 2024
Open
Open
Open
This was referenced May 19, 2024
Open
Open
@nachodev-ui nachodev-ui mentioned this pull request May 20, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request May 20, 2024
Open
@jfnw-capco jfnw-capco mentioned this pull request May 20, 2024
Open
@Chanuth-silva10 Chanuth-silva10 mentioned this pull request May 20, 2024
Closed
This was referenced May 20, 2024
Open
Open
This was referenced May 20, 2024
Open
Open
@sergivj sergivj mentioned this pull request May 21, 2024
Open
This was referenced May 21, 2024
Open
Open
@RTHariSankar RTHariSankar mentioned this pull request May 21, 2024
Open
@GitLukeW GitLukeW mentioned this pull request May 21, 2024
Open
@amylank22 amylank22 mentioned this pull request May 21, 2024
Open
@aqibawan12 aqibawan12 mentioned this pull request May 21, 2024
Open
@Poseidon-G Poseidon-G mentioned this pull request May 21, 2024
Open
@Crushoverride007 Crushoverride007 mentioned this pull request May 21, 2024
Open
@mx1613 mx1613 mentioned this pull request May 21, 2024
Closed
@DanneelsSophie DanneelsSophie mentioned this pull request May 22, 2024
Open
@heliumtank92 heliumtank92 mentioned this pull request Jun 8, 2024
Open
@Helmut-Tischler Helmut-Tischler mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
@dsypasit dsypasit mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work package: pigment-css Specific to @pigment-css/*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pigment-css] Support cross-referencing components
4 participants
@brijeshb42 @mui-bot @siriwatknp @oliviertassinari