Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Alert] Add slots and slotProps type to theme #41324

Merged
merged 4 commits into from
Mar 5, 2024
Merged

[material-ui][Alert] Add slots and slotProps type to theme #41324

merged 4 commits into from
Mar 5, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Mar 1, 2024

closes: #41322

@sai6855 sai6855 added bug 🐛 Something doesn't work package: material-ui Specific to @mui/material component: alert This is the name of the generic UI component, not the React module! labels Mar 1, 2024
@mui-bot
Copy link

mui-bot commented Mar 1, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41324--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6769dfb

@sai6855 sai6855 requested review from DiegoAndai and siriwatknp March 1, 2024 14:02
DiegoAndai
DiegoAndai approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this @sai6855

@DiegoAndai DiegoAndai merged commit fe5e34b into mui:master Mar 5, 2024
19 checks passed
@DiegoAndai DiegoAndai mentioned this pull request Mar 6, 2024
Merged
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
@sai6855 @mnajdova
[material-ui][Alert] Add slots and slotProps type to theme (mui#4…
ad401ee 
…1324)
@DiegoAndai DiegoAndai mentioned this pull request Mar 12, 2024
Merged
1 task
This was referenced May 19, 2024
Open
Open
Open
This was referenced May 19, 2024
Open
Open
@nachodev-ui nachodev-ui mentioned this pull request May 20, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request May 20, 2024
Open
@jfnw-capco jfnw-capco mentioned this pull request May 20, 2024
Open
@Chanuth-silva10 Chanuth-silva10 mentioned this pull request May 20, 2024
Closed
This was referenced May 20, 2024
Open
Open
This was referenced May 20, 2024
Open
Open
@sergivj sergivj mentioned this pull request May 21, 2024
Open
@NOUIY NOUIY mentioned this pull request May 21, 2024
Open
@DanneelsSophie DanneelsSophie mentioned this pull request May 25, 2024
Open
This was referenced May 25, 2024
Open
Open
@mattboddy47 mattboddy47 mentioned this pull request May 25, 2024
Open
This was referenced May 25, 2024
Open
Open
@arddluma arddluma mentioned this pull request May 25, 2024
Closed
This was referenced May 25, 2024
Open
Open
@realmarkoprifti realmarkoprifti mentioned this pull request May 25, 2024
Open
@nachodev-ui nachodev-ui mentioned this pull request May 25, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request May 25, 2024
Open
This was referenced May 26, 2024
Open
Open
Open
@Poseidon-G Poseidon-G mentioned this pull request May 26, 2024
Open
This was referenced May 26, 2024
Closed
Closed
@GitLukeW GitLukeW mentioned this pull request May 26, 2024
Open
@NOUIY NOUIY mentioned this pull request May 26, 2024
Open
@2310781001 2310781001 mentioned this pull request May 26, 2024
Open
@syedabdullahali syedabdullahali mentioned this pull request May 28, 2024
Open
This was referenced May 28, 2024
Open
Open
Open
@heliumtank92 heliumtank92 mentioned this pull request Jun 8, 2024
Open
@Helmut-Tischler Helmut-Tischler mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
@dsypasit dsypasit mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: alert This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[material-ui][Alert] Can't set slots in theme's defaultProps in 5.15.11
3 participants
@sai6855 @mui-bot @DiegoAndai