-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Add pigment-css-vite-ts starter example #41196
Conversation
siriwatknp
commented
Feb 20, 2024
•
edited
Loading
edited
- I have followed (at least) the PR section of the contributing guide.
Netlify deploy previewhttps://deploy-preview-41196--material-ui.netlify.app/ Bundle size report |
zero-vite
starter exampleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick writing review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we replace the zero with pigment-css
?
"react-dom": "latest" | ||
}, | ||
"devDependencies": { | ||
"@pigmentcss/vite-plugin": "latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
"preview": "vite preview" | ||
}, | ||
"dependencies": { | ||
"@pigmentcss/react": "latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have renamed the package, again :)
Tested. It works. curl https://codeload.github.com/siriwatknp/material-ui/tar.gz/zero-vite-starter | tar -xz --strip=2 material-ui-zero-vite-starter/examples/pigment-css-vite-ts
cd pigment-css-vite-ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢🚢