[docs-infra] Add external link arrow #41129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
commented
Feb 16, 2024
Netlify deploy previewhttps://deploy-preview-41129--material-ui.netlify.app/ Bundle size report |
alexfauquette
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
The technical solution looks good.
I taught the issue was about distinguishing internal cs external links. Something as follow:
a:not([href*="mui.com"]):not([href^="/"]):not([href^="#"])But distinguishing by "open a new tab" vs "move in the same tab" seems good too 👍
danilo-leal
approved these changes
Feb 16, 2024
danilo-leal
added
the
design
|
Nice, this could make it to the Link component #41129. We might want to disable it for image links 
For ads, it feels like it shouldn't be here: 
https://deploy-preview-41129--material-ui.netlify.app/material-ui/react-button/ |
|
Proposing a fix: #41181 |
oliviertassinari
added
the
component: link
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #41072
Out of scope: determine which links should be external by updating the list.
Added arrow to external links using CSS to detect
target="_blank".docs-external-link.mp4