Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] New way of providing API layout config #41106

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Feb 15, 2024

The PR review of mui/mui-x#11876 make me realise that if I add some props to customize the API pages, running the docs:api script will override them.

Two solutions:

  • Don't override a page that exist. Did not pick that one because those script are already complex, and I fear in a few month it will end up with people asking why their API page do not update as expected
  • Add the configuration in script itself (the path I took)

@mui-bot
Copy link

mui-bot commented Feb 15, 2024

Netlify deploy preview

https://deploy-preview-41106--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 8b2d9ab

@alexfauquette alexfauquette force-pushed the move-API--layout-config branch from 9d1607b to aa46984 Compare February 15, 2024 09:00
@alexfauquette alexfauquette added the scope: docs-infra Specific to the docs-infra product label Feb 15, 2024
@alexfauquette alexfauquette marked this pull request as ready for review February 15, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants