[docs-infra] Adjust the tabs and layout selection design #41084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
design
Netlify deploy previewhttps://deploy-preview-41084--material-ui.netlify.app/ Bundle size report |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Danilo Leal <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
✅ Deploy Preview for resonant-twilight-4b0c91 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/src/modules/components/ApiPage/sections/ToggleDisplayOption.tsx
Outdated
Show resolved
Hide resolved
zanivan
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Cool! Just one comment—not so related to the change itself, however it's an opportunity to polish this out:
I reckon the box-shadows could be softened a bit here, mostly in the dark theme. It'd be more consistent with the light mode, and look less muddy in the borders.
I tried this tiny tweak:
boxShadow: `${alpha(theme.palette.primaryDark[600], 0.1)} 0 2px 0 inset, ${alpha(theme.palette.primaryDark[900], 0.5, )} 0 -2px 1px inset, ${theme.palette.common.black} 0 1px 2px 0`,`
And it looked better IMO:
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
@alexfauquette little bump here; when you have the time! :) |
cipherlogs
pushed a commit
to cipherlogs/material-ui
that referenced
this pull request
Mar 8, 2024
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the component to toggle between different API content layout views from a toggle button to a dropdown menu. This does consist of an additional click, but ultimately, I feel like it improves the feature's discoverability. The "View" word within the button, clearly stating which view you're seeing, gives it away that you may find other options by clicking on the button. Regardless of the tooltip, the icons alone in the current version did not feel intuitive to use. I've received feedback that, at a glance, it was not clear what they were for. Aside from that, also added in some stray design tweaks.
https://deploy-preview-41084--material-ui.netlify.app/base-ui/react-button/components-api/#button
Related discussion: #40862 (comment)