-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[base-ui][docs] Improve Base UI traffic from Material UI #40875
Conversation
Netlify deploy previewhttps://deploy-preview-40875--material-ui.netlify.app/ Bundle size report |
Thinking about this section in the context of the Material UI Button page, I'm afraid we're going to confuse users with the (Material UI) Button Base component and the Base UI Button component. Maybe we should add more (could just be another sentence or two) to this section to help users understand why they'd pick the Base UI component? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then maybe something like this
Co-authored-by: Danilo Leal <[email protected]> Signed-off-by: Olivier Tassinari <[email protected]>
54c1aa4
to
6da6481
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! 🤙
See #40446 (comment) for why
Before https://deploy-preview-40446--material-ui.netlify.app/material-ui/react-button/#unstyled
After https://deploy-preview-40875--material-ui.netlify.app/material-ui/react-button/#unstyled