Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Simplify bug reproduction #40833

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 28, 2024

It's complex to have to manage CodeSandbox templates, I believe we can simplify the contribution experience by heavily relying on demo forks.

Preview: https://deploy-preview-40833--material-ui.netlify.app/material-ui/getting-started/support/#bug-reproductions

Equivalent to mui/mui-x#11849


Also encourage the use of StackBlitz to avoid the contributors from the community hitting a free limit with CodeSandbox.

@oliviertassinari oliviertassinari added the scope: code-infra Specific to the core-infra product label Jan 28, 2024
@zannager zannager requested a review from romgrk January 29, 2024 13:34
@oliviertassinari oliviertassinari removed the request for review from romgrk January 31, 2024 14:26
@oliviertassinari oliviertassinari marked this pull request as draft January 31, 2024 17:38
@oliviertassinari oliviertassinari marked this pull request as ready for review January 31, 2024 17:39
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! Nothing that I would change on it! Good wording as well! LGTM! :shipit:

@oliviertassinari
Copy link
Member Author

This goes hand-in-hand with mui/mui-x#11849, but hold on, I'm evolving that PR to factor in Romain feedback.

@oliviertassinari oliviertassinari merged commit 62f67a3 into mui:master Feb 3, 2024
22 checks passed
@oliviertassinari oliviertassinari deleted the simplify-reproduction branch February 3, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants