-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lab][TabContext] Support number type in value
#40829
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40829--material-ui.netlify.app/ Bundle size report |
oliviertassinari
added
the
component: tabs
This is the name of the generic UI component, not the React module!
label
Jan 28, 2024
|
oliviertassinari
changed the title
PR:[lab][TabContext] Support values other than string
[material-ui][tabs] Support TabContext values other than string
Jan 28, 2024
It fixes #40630 |
ZeeshanTamboli
added
bug 🐛
Something doesn't work
typescript
package: lab
Specific to @mui/lab
labels
Jan 29, 2024
ZeeshanTamboli
changed the title
[material-ui][tabs] Support TabContext values other than string
[lab][TabContext] Support number type in Jan 29, 2024
value
ZeeshanTamboli
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the contribution!
1 task
mostafa-rio
pushed a commit
to mostafa-rio/material-ui
that referenced
this pull request
Feb 3, 2024
Co-authored-by: S Srinidhi <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: tabs
This is the name of the generic UI component, not the React module!
package: lab
Specific to @mui/lab
typescript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40630