Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lab][TabContext] Support number type in value #40829

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

srinidhi9831
Copy link
Contributor

@srinidhi9831 srinidhi9831 commented Jan 28, 2024

Fixes #40630

@mui-bot
Copy link

mui-bot commented Jan 28, 2024

Netlify deploy preview

https://deploy-preview-40829--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against eff1ce9

@oliviertassinari oliviertassinari added the component: tabs This is the name of the generic UI component, not the React module! label Jan 28, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 28, 2024

@oliviertassinari oliviertassinari changed the title PR:[lab][TabContext] Support values other than string [material-ui][tabs] Support TabContext values other than string Jan 28, 2024
@ZeeshanTamboli
Copy link
Member

It fixes #40630

@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work typescript package: lab Specific to @mui/lab labels Jan 29, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][tabs] Support TabContext values other than string [lab][TabContext] Support number type in value Jan 29, 2024
@zannager zannager requested a review from DiegoAndai January 29, 2024 13:36
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution!

@ZeeshanTamboli ZeeshanTamboli merged commit 8bcb5f7 into mui:master Jan 29, 2024
25 of 26 checks passed
mostafa-rio pushed a commit to mostafa-rio/material-ui that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module! package: lab Specific to @mui/lab typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lab][TabContext] Support values other than string
5 participants