Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Alert] Deprecate components and componentsProps props #40681

Merged
merged 16 commits into from
Feb 16, 2024
Merged

[material-ui][Alert] Deprecate components and componentsProps props #40681

merged 16 commits into from
Feb 16, 2024

Conversation

DiegoAndai
Copy link
Member

Deprecate components and componentsProps props in favor of slots and slotProps respectively.

I wondered whether to deprecate action, icon, and iconMappings as well, but I'm not so sure, and it would be a bigger change, so I created a separate issue to discuss it eventually: #40680

@DiegoAndai DiegoAndai added deprecation New deprecation message package: material-ui Specific to @mui/material component: alert This is the name of the generic UI component, not the React module! labels Jan 18, 2024
@DiegoAndai DiegoAndai added this to the Material UI: v6 milestone Jan 18, 2024
@DiegoAndai DiegoAndai requested a review from siriwatknp January 18, 2024 19:20
@DiegoAndai DiegoAndai self-assigned this Jan 18, 2024
@mui-bot
Copy link

mui-bot commented Jan 18, 2024 •
edited
Loading

Netlify deploy preview

@material-ui/lab: parsed: +0.22% , gzip: -0.47% 😍

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 4abe7e5

@DiegoAndai DiegoAndai mentioned this pull request Jan 18, 2024
Merged
@DiegoAndai DiegoAndai mentioned this pull request Jan 19, 2024
Open
@DiegoAndai
Copy link
Member Author

Hey @siriwatknp! I updated this PR. I added the codemods and migration guide. For the codemods, I created a replaceComponentsWithSlots deprecations util, as the codemod should be the same for all components and componentsProps deprecations.

siriwatknp
siriwatknp reviewed Feb 16, 2024
View reviewed changes
packages/mui-material/src/Alert/Alert.test.js
},
skip: [
'componentsProp',
'slotPropsCallback', // not supported yet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

siriwatknp
siriwatknp approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Awesome

@DiegoAndai DiegoAndai merged commit 1077906 into mui:master Feb 16, 2024
22 checks passed
@DiegoAndai DiegoAndai deleted the alert-v6-deprecations branch February 16, 2024 13:52
@DiegoAndai DiegoAndai mentioned this pull request Feb 26, 2024
Closed
17 tasks
This was referenced May 24, 2024
Open
Open
@Crushoverride007 Crushoverride007 mentioned this pull request Jun 5, 2024
Open
This was referenced Jul 16, 2024
Open
Open
Open
@Crushoverride007 Crushoverride007 mentioned this pull request Jul 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova left review comments

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees

@DiegoAndai DiegoAndai

Labels
component: alert This is the name of the generic UI component, not the React module! deprecation New deprecation message package: material-ui Specific to @mui/material
Projects
None yet
Milestone
Material UI: v6
Development

Successfully merging this pull request may close these issues.
4 participants
@DiegoAndai @mui-bot @mnajdova @siriwatknp