-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Add stray design adjustments #40623
[docs-infra] Add stray design adjustments #40623
Conversation
Netlify deploy previewBundle size report |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but those are ultimately a matter of opinion, so feel free to merge it when you think it's ready 🚀
'&:active': { transform: 'scale(.98)' }, | ||
'&:focus-visible': { | ||
outline: `3px solid ${alpha(theme.palette.primary[500], 0.5)}`, | ||
outlineOffset: '2px', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, on ButtonBase, this is ambitious. There will likely be a lot more reset needed, #40747 sounds like only the tip of the iceberg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've circled around both the marketing pages and the documentation, and aside from the instance in your PR, nothing crazy stood out. In any case, do let me know if you find any further regressions! 👍 Many buttons/links were missing proper focus state treatment prior to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many buttons/links were missing proper focus state treatment prior to this.
@danilo-leal True, this might make for the best tradeoff. We never thought about this use case for ButtonBase when introducing it, nice 😄.
find any further regressions
I mostly saw broken cases around tabs.
General run-through:
Examples: