-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Fix anchor links in API pages #40450
[docs-infra] Fix anchor links in API pages #40450
Conversation
Netlify deploy previewhttps://deploy-preview-40450--material-ui.netlify.app/ Bundle size report |
targetName={pageContent.name} | ||
componentName={pageContent.name} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with a solution that minimize the number of types that we manipulate. It seems simpler to kebab case convert at the very end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed classes did not have the wrapper because they did not have the scrollMarginTop
property. I'm adding a commit to fix that.
The scroll is not well aligned for the first two row, because the scroll margin top is blocked by the overflow hidden
I tried different config but nothing worked on chrome, so I dropped the topic
fa1ce87
to
713b4c9
Compare
Oh wow, I didn't know this. Another reason why #40476 then 😄 |
Co-authored-by: alexandre <[email protected]>
Fix #40395 (comment)
Before: https://deploy-preview-40395--material-ui.netlify.app/base-ui/react-menu/components-api/#menu-item-classes-focusVisible
After: https://deploy-preview-40450--material-ui.netlify.app/base-ui/react-menu/components-api/#menu-item-classes-focusVisible