-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][docs] Revise the Divider page #40356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
Improvements or additions to the documentation
component: divider
This is the name of the generic UI component, not the React module!
package: material-ui
Specific to @mui/material
labels
Dec 29, 2023
62 tasks
Netlify deploy previewBundle size report |
samuelsycamore
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tentatively approving because I'm really just nitpicking at this point 😁 nice job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: divider
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
package: material-ui
Specific to @mui/material
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a general formatting, editing, and demo simplification revision of the Material UI Divider page. I've removed a couple of demos that I felt weren't necessarily adding a lot and were a bit more list-related than anything else. This PR also hopefully closes #34248, which was the motivation for it in the first place when I found it earlier today! It felt like a reasonably quick win. :)
https://deploy-preview-40356--material-ui.netlify.app/material-ui/react-divider/