Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Revise and expand Joy UI Button doc #35737

Merged
merged 4 commits into from
Jan 9, 2023
Merged

[docs] Revise and expand Joy UI Button doc #35737

merged 4 commits into from
Jan 9, 2023

Conversation

samuelsycamore
Copy link
Contributor

Part of #33998

This PR revises and expands the Joy UI Button doc. Notable changes include:

  • rearranging and reformatting to match the latest style
  • adding a couple basic demos
  • accessibility and anatomy

While I was comparing this doc with its sister in the Base docs, I noticed that the Base page had a tiny inconsistency in how it's organized, so I went ahead and changed that here because it's not worth creating a PR for on its own.

@samuelsycamore samuelsycamore added docs Improvements or additions to the documentation component: button This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Jan 5, 2023
@mui-bot
Copy link

mui-bot commented Jan 5, 2023

Messages
📖 Netlify deploy preview: https://deploy-preview-35737--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against a191301

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great to me! 👌

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Smooth!

@michaldudak michaldudak merged commit 401c104 into mui:master Jan 9, 2023
@samuelsycamore samuelsycamore deleted the joy-button branch April 3, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants