Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][docs] Revise the Alert demo page #34892

Merged
merged 18 commits into from
Jan 9, 2024
Merged

[material-ui][docs] Revise the Alert demo page #34892

merged 18 commits into from
Jan 9, 2024

Conversation

samuelsycamore
Copy link
Contributor

@samuelsycamore samuelsycamore commented Oct 26, 2022 •
edited
Loading

@samuelsycamore samuelsycamore added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material component: alert This is the name of the generic UI component, not the React module! labels Oct 26, 2022
@samuelsycamore samuelsycamore mentioned this pull request Oct 26, 2022
Merged
@mui-bot
Copy link

mui-bot commented Oct 26, 2022 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against fa8986e

oliviertassinari
oliviertassinari reviewed Oct 26, 2022
View reviewed changes
docs/.link-check-errors.txt Outdated Show resolved Hide resolved
docs/data/material/components/alert/alert.md Outdated Show resolved Hide resolved
docs/data/material/components/alert/alert.md Outdated Show resolved Hide resolved
docs/data/material/components/alert/alert.md Show resolved Hide resolved
docs/data/material/components/alert/alert.md Outdated Show resolved Hide resolved
samuelsycamore and others added 2 commits October 26, 2022 14:13
@samuelsycamore @oliviertassinari
Apply suggestions from code review
3b15c84 
Co-authored-by: Olivier Tassinari <[email protected]>
Signed-off-by: Sam Sycamore <[email protected]>
@samuelsycamore
prettier and link check
9b7c291
@oliviertassinari oliviertassinari mentioned this pull request Oct 29, 2022
Closed
2 tasks
@samuelsycamore samuelsycamore mentioned this pull request Oct 31, 2022
Closed
@samuelsycamore samuelsycamore mentioned this pull request Nov 15, 2022
Closed
62 tasks
@samuelsycamore
Copy link
Contributor Author

@oliviertassinari I removed the info about the overriding props, and moved the Anatomy section to the bottom of the page. We discussed creating a new tab on the Component page for Anatomy in a Core meeting, but until we implement it, I think this page structure works. What do you think?

@oliviertassinari

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 26, 2023
@samuelsycamore samuelsycamore added the on hold There is a blocker, we need to wait label Sep 1, 2023
@samuelsycamore

This comment was marked as resolved.

Sign in to view
@samuelsycamore samuelsycamore changed the title [docs] Revise and expand the Material UI "Alert" page [docs][material-ui] Revise and expand the "Alert" page Sep 1, 2023
@samuelsycamore samuelsycamore removed the on hold There is a blocker, we need to wait label Jan 5, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 5, 2024
@samuelsycamore
Copy link
Contributor Author

Reviving this one with the updated component demo page format.

danilo-leal
danilo-leal approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome — dropping an approval already! Left some somewhat small considerations there.

docs/data/material/components/alert/alert.md Outdated Show resolved Hide resolved
docs/data/material/components/alert/alert.md Show resolved Hide resolved
docs/data/material/components/alert/alert.md Outdated Show resolved Hide resolved
@samuelsycamore samuelsycamore changed the title [docs][material-ui] Revise and expand the "Alert" page [material-ui][docs] Revise the Alert demo page Jan 8, 2024
@samuelsycamore
Copy link
Contributor Author

Expanded in the Intro and added a Usage section like we did for the Snackbar page. I think it's good to go now but let me know what you think!

danilo-leal
danilo-leal approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! 🎉

@siriwatknp siriwatknp merged commit 440b36b into mui:master Jan 9, 2024
19 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
@samuelsycamore @mnajdova
[material-ui][docs] Revise the Alert demo page (mui#34892)
90a56c6
@samuelsycamore samuelsycamore deleted the material-alert branch April 3, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
component: alert This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samuelsycamore @mui-bot @oliviertassinari @danilo-leal @siriwatknp