Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add "Overview" page to Material UI docs #32643

Merged
merged 20 commits into from
May 30, 2022
Merged

[docs] Add "Overview" page to Material UI docs #32643

merged 20 commits into from
May 30, 2022

Conversation

samuelsycamore
Copy link
Contributor

@samuelsycamore samuelsycamore commented May 5, 2022

This PR adds an Overview page to the Getting started section of the Material UI docs, following the same format as #32310.

Once this PR gets merged, I'll return to the Base Overview page and link back to this one when mentioning Material UI. Might as well just add this here too. 😁

@samuelsycamore samuelsycamore added the docs Improvements or additions to the documentation label May 5, 2022
@mui-bot
Copy link

mui-bot commented May 5, 2022

No bundle size changes

Generated by 🚫 dangerJS against ba673d2

Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some initial suggestions.

docs/data/material/getting-started/overview/overview.md Outdated Show resolved Hide resolved
docs/data/material/getting-started/overview/overview.md Outdated Show resolved Hide resolved
docs/data/material/getting-started/overview/overview.md Outdated Show resolved Hide resolved
Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see these pages being added. It's always bothered me that we link to installation. :)

docs/data/base/getting-started/overview/overview.md Outdated Show resolved Hide resolved
docs/data/base/getting-started/overview/overview.md Outdated Show resolved Hide resolved

## Introduction

Material UI is an open-source React component library that implements Google's [Material Design](https://material.io/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Material UI is an open-source React component library that implements Google's [Material Design](https://material.io/).
Material UI is an open-source React component library that implements version 2 of Google's [Material Design](https://material.io/).

Copy link
Member

@oliviertassinari oliviertassinari May 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We take the risk to forget to update "version 2" with Material UI v6 which would cover Material Design v3 if everything goes smoothly.

If we really want to mention a version, then I think that we should rephrase it, in the current wording, it could sounds like v2 is our ultimate goal. Instead, we could say something around "currently v2". e.g.

Suggested change
Material UI is an open-source React component library that implements Google's [Material Design](https://material.io/).
Material UI is an open-source React component library that implements Google's [Material Design](https://material.io/).
It currently only supports Material Design v2, see [issue #12134](foo/bar) for the support of Material Design v3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about what's the intended direction regarding Material's v3, it doesn't seem to exist alignment in this matter — see #32643 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what I've added based on my understanding of the situation—please correct me if I'm wrong:

:::info
Material UI currently supports Material Design v2.
Adoption of v3 is tentatively planned for Material UI v6.
You can follow [this GitHub issue](https://github.com/mui/material-ui/issues/29345) for future updates.
:::

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively: we could always just leave this out completely if we aren't prepared to say yes or no to v3 adoption. 😅

docs/data/material/getting-started/overview/overview.md Outdated Show resolved Hide resolved
docs/data/material/getting-started/overview/overview.md Outdated Show resolved Hide resolved
docs/data/material/getting-started/overview/overview.md Outdated Show resolved Hide resolved
docs/data/base/getting-started/overview/overview.md Outdated Show resolved Hide resolved
docs/data/base/getting-started/overview/overview.md Outdated Show resolved Hide resolved

## Introduction

Material UI is an open-source React component library that implements Google's [Material Design](https://material.io/).
Copy link
Member

@oliviertassinari oliviertassinari May 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We take the risk to forget to update "version 2" with Material UI v6 which would cover Material Design v3 if everything goes smoothly.

If we really want to mention a version, then I think that we should rephrase it, in the current wording, it could sounds like v2 is our ultimate goal. Instead, we could say something around "currently v2". e.g.

Suggested change
Material UI is an open-source React component library that implements Google's [Material Design](https://material.io/).
Material UI is an open-source React component library that implements Google's [Material Design](https://material.io/).
It currently only supports Material Design v2, see [issue #12134](foo/bar) for the support of Material Design v3.

docs/data/material/getting-started/overview/overview.md Outdated Show resolved Hide resolved
docs/data/material/getting-started/overview/overview.md Outdated Show resolved Hide resolved
docs/data/base/getting-started/overview/overview.md Outdated Show resolved Hide resolved
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mbrookes mbrookes merged commit 381b26f into mui:master May 30, 2022
oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request May 30, 2022
oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request May 30, 2022
oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request May 30, 2022
@samuelsycamore samuelsycamore deleted the material-ui-overview branch April 3, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants