Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Copy TextareaAutosize docs to Base #32034

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

michaldudak
Copy link
Member

Copied the TextareaAutosize content over to Base docs. Also updated the incorrect bundle size.

@michaldudak michaldudak requested a review from a team March 29, 2022 13:32
@michaldudak michaldudak added docs Improvements or additions to the documentation component: TextareaAutosize The React component. labels Mar 29, 2022
@mui-bot
Copy link

mui-bot commented Mar 29, 2022

No bundle size changes

Generated by 🚫 dangerJS against f8ea5bf

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the link on https://mui.com/base/react-input/#multiline to point to this new page.

@mnajdova
Copy link
Member

Should we link the components which are basically duplicated in both base and Material UI by adding an unstyled section on the Material UI page?

@michaldudak
Copy link
Member Author

Should we link the components which are basically duplicated in both base and Material UI by adding an unstyled section on the Material UI page?

We can explain that the @mui/material instance is just a re-export and the component lives inside the Base package. Perhaps someone may find it useful if they intend to use the library for just the utilities (so they can import from Base instead).

@mnajdova
Copy link
Member

We can explain that the @mui/material instance is just a re-export and the component lives inside the Base package. Perhaps someone may find it useful if they intend to use the library for just the utilities (so they can import from Base instead).

Exactly, let's do it! It probably should be enough to just link the unstyled page, as done in the modal - https://mui.com/components/modal/#unstyled

@michaldudak
Copy link
Member Author

It's a bit different in this case as we don't have an unstyled version of TextareaAutosize. It's exactly the same thing. I emphasized this in the description. Please let me know if you find it better.

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@michaldudak michaldudak merged commit 50966df into mui:master Mar 30, 2022
@michaldudak michaldudak deleted the docs/textarea branch March 30, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: TextareaAutosize The React component. docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants