Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Create TablePaginationUnstyled docs #32018

Merged
merged 6 commits into from
Mar 29, 2022

Conversation

michaldudak
Copy link
Member

Extracted the table pagination section from Table docs and moved them to Base docs.

@michaldudak michaldudak added component: TablePagination The React component. docs Improvements or additions to the documentation labels Mar 28, 2022
@michaldudak michaldudak changed the title Docs/table-pagination [docs] Create TablePaginationUnstyled docs Mar 28, 2022
@michaldudak michaldudak requested a review from a team March 28, 2022 08:05
@mui-bot
Copy link

mui-bot commented Mar 28, 2022

No bundle size changes

Generated by 🚫 dangerJS against 80c11d1

@@ -43,6 +43,6 @@
"forwardsRefTo": "HTMLTableCellElement",
"filename": "/packages/mui-base/src/TablePaginationUnstyled/TablePaginationUnstyled.tsx",
"inheritance": null,
"demos": "<ul><li><a href=\"/material-ui/react-table/\">Tables</a></li></ul>",
"demos": "<ul><li><a href=\"/base/components/table-pagination/\">Table Pagination</a></li>\n<li><a href=\"/material-ui/react-table/\">Tables</a></li></ul>",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong. 🤔

Copy link
Member

@siriwatknp siriwatknp Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaldudak I think you have to remove TablePaginationUnstyled in the markdown header from docs/data/material/components/tables/tables.md

and then run docs:api again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have forgotten about this. Thanks!

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 29, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 29, 2022
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 29, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 29, 2022
@michaldudak michaldudak merged commit 3353a89 into mui:master Mar 29, 2022
@michaldudak michaldudak deleted the docs/table-pagination branch March 29, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: TablePagination The React component. docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants