-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Move SwitchUnstyled docs to the Base space #31964
Conversation
# Switch | ||
|
||
<p class="description">Switches toggle the state of a single setting on or off.</p> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add the features list?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should add it in all components. The Switch is a rather simple component, not sure it deserves a features list :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, yeah... it's a valid point. Though I confess I like the consistency of having in all of them, even in simpler ones like the Switch. I appreciate the Radix team for doing that, it's easy to scan through!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, from their list, I would expect all components to support those features of hey are input components :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revisit this for all components and make sure we at least don't miss it on the more complex ones.
Co-authored-by: danilo leal <[email protected]>
Moved the unstyled section of the Select docs to Base documentation.
Demos were not modified, nothing new was added.
Preview: https://deploy-preview-31964--material-ui.netlify.app/base/react-switch/