Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Move SwitchUnstyled docs to the Base space #31964

Merged
merged 6 commits into from
Mar 31, 2022

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Mar 23, 2022

Moved the unstyled section of the Select docs to Base documentation.
Demos were not modified, nothing new was added.

Preview: https://deploy-preview-31964--material-ui.netlify.app/base/react-switch/

@michaldudak michaldudak added component: select This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Mar 23, 2022
@mui-bot
Copy link

mui-bot commented Mar 23, 2022

No bundle size changes

Generated by 🚫 dangerJS against 0fc63e4

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 24, 2022
@michaldudak michaldudak added component: switch This is the name of the generic UI component, not the React module! and removed component: select This is the name of the generic UI component, not the React module! labels Mar 25, 2022
@michaldudak michaldudak requested a review from a team March 25, 2022 11:04
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 25, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 25, 2022
# Switch

<p class="description">Switches toggle the state of a single setting on or off.</p>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the features list?!

Copy link
Member

@mnajdova mnajdova Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add it in all components. The Switch is a rather simple component, not sure it deserves a features list :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, yeah... it's a valid point. Though I confess I like the consistency of having in all of them, even in simpler ones like the Switch. I appreciate the Radix team for doing that, it's easy to scan through!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, from their list, I would expect all components to support those features of hey are input components :D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revisit this for all components and make sure we at least don't miss it on the more complex ones.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 29, 2022
@michaldudak michaldudak merged commit 895bb3f into mui:master Mar 31, 2022
@michaldudak michaldudak deleted the docs/switch branch March 31, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: switch This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants