Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NoSsr] Copy docs to the Base space #31956

Merged
merged 3 commits into from
Mar 28, 2022
Merged

[NoSsr] Copy docs to the Base space #31956

merged 3 commits into from
Mar 28, 2022

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Mar 23, 2022 •
edited
Loading

Copied the content of NoSsr docs and changed imports in demos

Preview: http://deploy-preview-31956--material-ui.netlify.app/base/react-no-ssr

@michaldudak michaldudak added the docs Improvements or additions to the documentation label Mar 23, 2022
@michaldudak michaldudak mentioned this pull request Mar 23, 2022
Closed
17 tasks
@mui-bot
Copy link

mui-bot commented Mar 23, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 345d181

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 23, 2022
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Mar 23, 2022
@michaldudak michaldudak requested a review from a team March 25, 2022 11:02
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 25, 2022
siriwatknp
siriwatknp approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. I think the content can be refined later (eg. adding real example, mention client-only libraries that need NoSsr, or link to some blog that explains server-client in more detail)

@michaldudak michaldudak merged commit 34855b2 into mui:master Mar 28, 2022
@michaldudak michaldudak deleted the docs/nossr branch March 28, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaldudak @mui-bot @siriwatknp