[TrapFocus] Move docs to Base and drop the Unstyled prefix #31954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
component: FocusTrap
17 tasks
github-actions
bot
added
the
PR: out-of-date
michaldudak
force-pushed
the
docs/trap-focus
branch
from
50bd598 to
147769b
Compare
github-actions
bot
removed
the
PR: out-of-date
hbjORbj
approved these changes
Mar 24, 2022
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the TrapFocus docs and demos to the Base space.
Since it's an unstable component, I decided to leave the documentation only in the Base space. The
Unstable_TrapFocusexport from @mui/material remains only for backwards compatibilityBreaking change in @mui/base
Removed the
Unstyled_prefix from the Base export (it remains in the Material UI export, though).side note: wouldn't it make more sense if this component was called "FocusTrap"? (cc @samuelsycamore)