Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add InputUnstyled docs #31881

Merged
merged 22 commits into from
Mar 25, 2022
Merged

[docs] Add InputUnstyled docs #31881

merged 22 commits into from
Mar 25, 2022

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Mar 18, 2022 •
edited
Loading

@mui-bot
Copy link

mui-bot commented Mar 18, 2022 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against e7be017

@danilo-leal danilo-leal added package: base-ui Specific to @mui/base component: text field This is the name of the generic UI component, not the React module! labels Mar 18, 2022
@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Mar 18, 2022
@mnajdova mnajdova marked this pull request as ready for review March 21, 2022 08:34
@michaldudak
Copy link
Member

Could you make the adornments use the same font that the input itself?

Also, the eye icon seems to be placed too high:

Screen Shot 2022-03-21 at 11 02 55

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 21, 2022
@mnajdova mnajdova mentioned this pull request Mar 21, 2022
Closed
17 tasks
@mnajdova
Copy link
Member Author

Could you make the adornments use the same font that the input itself?
Also, the eye icon seems to be placed too high

On it! I noticed too that I am missing a demo for multiline, will add that one too.

samuelsycamore
samuelsycamore reviewed Mar 21, 2022
View reviewed changes
docs/data/base/components/input/input.md Outdated Show resolved Hide resolved
docs/data/base/components/input/input.md Outdated Show resolved Hide resolved
docs/data/base/components/input/input.md Outdated Show resolved Hide resolved
docs/data/base/components/input/input.md Outdated Show resolved Hide resolved
docs/data/base/components/input/input.md Show resolved Hide resolved
docs/data/base/components/input/input.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 21, 2022
danilo-leal
danilo-leal approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 23, 2022
samuelsycamore
samuelsycamore reviewed Mar 23, 2022
View reviewed changes
docs/data/base/components/input/input.md Outdated Show resolved Hide resolved
docs/data/base/components/input/input.md Outdated Show resolved Hide resolved
docs/data/base/components/input/input.md Outdated Show resolved Hide resolved
docs/data/base/components/input/input.md Outdated Show resolved Hide resolved
docs/data/base/components/input/input.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 24, 2022
@mnajdova mnajdova merged commit a919615 into mui:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelsycamore samuelsycamore samuelsycamore left review comments

@danilo-leal danilo-leal danilo-leal approved these changes

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mnajdova @mui-bot @michaldudak @danilo-leal @samuelsycamore