Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Copy ClickAwayListener docs to Base #31878

Merged
merged 2 commits into from
Mar 23, 2022
Merged

[docs] Copy ClickAwayListener docs to Base #31878

merged 2 commits into from
Mar 23, 2022

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Mar 18, 2022 •
edited
Loading

Copied the ClickAwayListener docs and modified the imports in the demos.

Preview: https://deploy-preview-31878--material-ui.netlify.app/base/react-click-away-listener/

@michaldudak michaldudak added component: ClickAwayListener The React component docs Improvements or additions to the documentation labels Mar 18, 2022
@mui-bot
Copy link

mui-bot commented Mar 18, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against e207309

michaldudak
michaldudak commented Mar 18, 2022
View reviewed changes
docs/data/base/components/click-away-listener/click-away-listener.md

{{"demo": "LeadingClickAway.js"}}

> ⚠️ In this mode, only interactions on the scrollbar of the document is ignored.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliviertassinari I saw you introduced this comment. Would you mind elaborating on it? It seems that clicking on a scrollbar doesn't trigger onClickAway in any mode (at least in my setup - Edge on Windows)

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 21, 2022
@michaldudak michaldudak force-pushed the docs/clickawaylistener branch from dae9b54 to e207309 Compare March 22, 2022 11:56
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 22, 2022
@michaldudak michaldudak mentioned this pull request Mar 22, 2022
Closed
17 tasks
mnajdova
mnajdova approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with merging it and iterating on the content in a follow up

siriwatknp
siriwatknp approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@michaldudak michaldudak merged commit 56e5d02 into mui:master Mar 23, 2022
@michaldudak michaldudak deleted the docs/clickawaylistener branch March 23, 2022 15:35
oliviertassinari
oliviertassinari reviewed Apr 30, 2022
View reviewed changes
docs/pages/api-docs/click-away-listener.js
import mapApiPageTranslations from 'docs/src/modules/utils/mapApiPageTranslations';
import jsonPageContent from './click-away-listener.json';

export default function Page(props) {
Copy link
Member

@oliviertassinari oliviertassinari Apr 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot to add a redirection for this file, please let's always redirect older URLs. It was raised in https://app.ahrefs.com/site-audit/3524616/10/data-explorer?columns=pageRating%2Curl%2Ctraffic%2ChttpCode%2Cdepth%2Ccompliant%2CincomingAllLinks%2Corigin&filterCollapsed=true&filterId=c8b4cd2c48fbde5a00dcef1da5e81f8b&issueId=c64dae3f-d0f4-11e7-8ed1-001e67ed4656&sorting=-pageRating. I'm taking care of it in #32515.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@siriwatknp siriwatknp siriwatknp approved these changes

@mnajdova mnajdova mnajdova approved these changes

@samuelsycamore samuelsycamore Awaiting requested review from samuelsycamore

Assignees
No one assigned
Labels
component: ClickAwayListener The React component docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaldudak @mui-bot @oliviertassinari @mnajdova @siriwatknp