Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add docs page for unstyled popper #31813

Merged
merged 15 commits into from
Mar 31, 2022
Merged

[docs] Add docs page for unstyled popper #31813

merged 15 commits into from
Mar 31, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Mar 15, 2022 •
edited
Loading

🖥 Preview

@mui-bot
Copy link

mui-bot commented Mar 15, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against c1beeda

@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Mar 15, 2022
@siriwatknp siriwatknp mentioned this pull request Mar 16, 2022
Closed
17 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 21, 2022
@siriwatknp siriwatknp marked this pull request as ready for review March 24, 2022 08:59
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 24, 2022
michaldudak
michaldudak reviewed Mar 24, 2022
View reviewed changes
docs/data/base/components/popper/popper.md Outdated Show resolved Hide resolved
docs/data/base/components/popper/popper.md Outdated Show resolved Hide resolved
docs/data/base/components/popper/popper.md Outdated Show resolved Hide resolved
docs/data/material/components/popper/popper.md Show resolved Hide resolved
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 24, 2022
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Mar 25, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 25, 2022
@michaldudak michaldudak changed the title [docs] add docs page for unstyled popper [docs] Add docs page for unstyled popper Mar 25, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 28, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 29, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 29, 2022
@siriwatknp siriwatknp requested a review from michaldudak March 30, 2022 15:54
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 30, 2022
michaldudak
michaldudak approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@siriwatknp siriwatknp merged commit 4c13270 into mui:master Mar 31, 2022
oliviertassinari
oliviertassinari reviewed Apr 7, 2022
View reviewed changes
docs/data/material/components/popper/popper.md
githubLabel: 'component: Popper'
unstyled: /base/react-popper/
packageName: '@mui/base'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not in the base, it's in @mui/material, no?

Suggested change
packageName: '@mui/base'

@michaldudak michaldudak mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@michaldudak michaldudak michaldudak approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

@samuelsycamore samuelsycamore Awaiting requested review from samuelsycamore

@danilo-leal danilo-leal Awaiting requested review from danilo-leal

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siriwatknp @mui-bot @oliviertassinari @michaldudak @danilo-leal