Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add ButtonUnstyled page on the base docs #31391

Closed
wants to merge 1 commit into from

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Mar 9, 2022

@@ -23,6 +23,6 @@
"forwardsRefTo": "HTMLButtonElement",
"filename": "/packages/mui-base/src/ButtonUnstyled/ButtonUnstyled.tsx",
"inheritance": null,
"demos": "<ul><li><a href=\"/components/buttons/\">Buttons</a></li></ul>",
"demos": "<ul><li><a href=\"D:/workspace/mui/\">Mui</a></li></ul>",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops something is off with the docs generation, could be windows related, will check tomorrow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the build it does not look that it is related to Windows only, maybe we should still wait for adding API & demos and linking them to the new packages? cc @siriwatknp can you check?

@@ -33,7 +33,7 @@ const useUtilityClasses = (ownerState: ButtonUnstyledOwnerState) => {
*
* Demos:
*
* - [Buttons](https://mui.com/components/buttons/)
* - [Mui](https://mui.comD:/workspace/mui/)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mui-bot
Copy link

mui-bot commented Mar 9, 2022

No bundle size changes

Generated by 🚫 dangerJS against f9b05a0

@siriwatknp
Copy link
Member

@mnajdova I'm closing this PR due to #31395 (@samuelsycamore has commented on the PR)

@siriwatknp siriwatknp closed this Mar 11, 2022
@mnajdova
Copy link
Member Author

Alright, I am tackling modal next

@siriwatknp
Copy link
Member

#31395

Can you review #31395 first because there are build scripts fixes included, it blocks other components.

@zannager zannager added the docs Improvements or additions to the documentation label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants