[test] Run React 18 integration tests with new createRoot API #26672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
test/concurrent-react
branch
from
c7bdf1e to
4daf16f
Compare
github-actions
bot
added
PR: out-of-date
eps1lon
force-pushed
the
test/concurrent-react
branch
3 times, most recently
from
e4cc31e to
eec31aa
Compare
eps1lon
force-pushed
the
test/concurrent-react
branch
from
eec31aa to
7a69c35
Compare
eps1lon
force-pushed
the
test/concurrent-react
branch
from
7a69c35 to
6c5e504
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4 tasks
eps1lon
force-pushed
the
test/concurrent-react
branch
from
691c693 to
b6034d9
Compare
eps1lon
force-pushed
the
test/concurrent-react
branch
from
b70a8bf to
a8a746d
Compare
eps1lon
changed the title
eps1lon
force-pushed
the
test/concurrent-react
branch
from
c394a46 to
399f5af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing with React 18 in 399f5af: https://app.circleci.com/pipelines/github/mui-org/material-ui/48718/workflows/89980172-722c-433a-8ce1-8a14202ca20f
It's mostly looking fine. There are some TODO items where we either can't run with
createRootor have to disableStrictMode(due to Strict Effects).I'll work on the remaining TODO items incrementally. We should start continously testing integration though by merging this PR.