Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nextpnr, iverilog, yosys and scopehal-apps #9444

Merged
merged 5 commits into from
Aug 28, 2021
Merged

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Aug 22, 2021

A regular bump to pick latest enhancements.

Note that the failure of scopehal-apps on MINGW32 is expected.

@lazka
Copy link
Member

lazka commented Aug 24, 2021

The scopehal build seems to fail for ucrt64 here: https://github.com/azonenberg/scopehal-apps/blob/41c1fbad9192fcd9aadeffe761c3202171f2ed0a/src/glscopeclient/CMakeLists.txt#L156 (it references paths which don't exist under ucrt64)

Is ucrt not supported?

@umarcor
Copy link
Contributor Author

umarcor commented Aug 26, 2021

Actually, I think that the whole section you referenced (https://github.com/azonenberg/scopehal-apps/blob/41c1fbad9192fcd9aadeffe761c3202171f2ed0a/src/glscopeclient/CMakeLists.txt#L131-L189) should not be executed when building the MSYS2 packages. That is copying content to dist_windows_x64, for generating an standalone zipfile.

@azonenberg, wdyt?

@lazka
Copy link
Member

lazka commented Aug 26, 2021

I might be wrong, it just looked like it based on the error in CI:

2021-08-22T20:16:51.0589228Z [ 99%] �[32m�[1mLinking CXX executable glscopeclient.exe�[0m
2021-08-22T20:16:53.5310123Z [ 99%] Built target glscopeclient
2021-08-22T20:16:53.6383330Z [100%] �[34m�[1mCreating dist/windows_x64...�[0m
2021-08-22T20:16:54.3321367Z cp: cannot stat '/mingw64/share/licenses': No such file or directory
2021-08-22T20:16:54.3333014Z make[2]: *** [src/glscopeclient/CMakeFiles/dist_windows_x64.dir/build.make:78: src/glscopeclient/CMakeFiles/dist_windows_x64] Error 1

@umarcor
Copy link
Contributor Author

umarcor commented Aug 26, 2021

@lazka, I was acknowledging that it might be an oversight on my/our/scopehal-apps' side, thus, confirming your pointer 😉.

@lazka lazka merged commit 4ff7a1f into msys2:master Aug 28, 2021
@lazka
Copy link
Member

lazka commented Aug 28, 2021

I've dropped the ucrt64 build for now

@Biswa96
Copy link
Member

Biswa96 commented Aug 28, 2021

I shall send some patches to upstream. Let see how it goes.

@umarcor umarcor deleted the eda branch August 29, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants