Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghdl: update to 1.0.0 #7880

Merged
merged 1 commit into from
Feb 4, 2021
Merged

ghdl: update to 1.0.0 #7880

merged 1 commit into from
Feb 4, 2021

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Feb 3, 2021

After almost 20 years of development, GHDL 1.0.0 was tagged! 🎉

I didn't remove pkgver(), because I expect it to be required in future updates.

@lazka, is there any problem with releasing 1.0.0 and the next update being something such as 1.0.0.r75.g55555555?

@Biswa96
Copy link
Member

Biswa96 commented Feb 3, 2021

is there any problem with releasing 1.0.0 and the next update being something such as 1.0.0.r75.g55555555?

If you just follow the basic PKGBUILD version rules there will be no issue. Also there is a vercmp tool which can help to compare version numbers to check if it is downgrade or upgrade.

@lazka
Copy link
Member

lazka commented Feb 3, 2021

What's the point of switching between a dynamic pkgver and a static one?

If ghdl does proper releases you could just switch to building tarballs like other packages. Or just keep things as is..

@umarcor
Copy link
Contributor Author

umarcor commented Feb 4, 2021

@lazka, GHDL is tagged once a year. Meanwhile, commit shas are used. We hope to have some more structured tagging in the future. Switching to proper semver tags was the first step. But it is not ready yet. That's why we've been using dynamic pkgver for the last months. However, this specific commit is tagged nicely, so I thought it'd be good to have 1.0.0 instead of 1.0.0.r0.g2fb2384d (which is the output of pkgver). The next tag, in a couple of weeks or month, will use pkgver() again.

@Biswa96, thanks for the reference to vercmp. I was told about it before, but I forgot. Sorry about that.

@lazka
Copy link
Member

lazka commented Feb 4, 2021

ok, fair enough.

@lazka lazka merged commit 238c5ea into msys2:master Feb 4, 2021
@umarcor umarcor deleted the ghdl branch February 4, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants