Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iverilog: add v12.0.rc #7341

Closed
wants to merge 11 commits into from
Closed

iverilog: add v12.0.rc #7341

wants to merge 11 commits into from

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Nov 28, 2020

This PR adds package iverilog: steveicarus/iverilog (iverilog.icarus.com). It's "a Verilog simulation and synthesis tool".

mingw-w64-iverilog/PKGBUILD Outdated Show resolved Hide resolved
mingw-w64-iverilog/PKGBUILD Outdated Show resolved Hide resolved
mingw-w64-iverilog/PKGBUILD Outdated Show resolved Hide resolved
@lazka lazka added the needinfo label Nov 28, 2020
@umarcor
Copy link
Contributor Author

umarcor commented Nov 28, 2020

FTR: https://github.com/steveicarus/iverilog/blob/master/README.txt points to https://github.com/steveicarus/iverilog/blob/master/mingw.txt, which points to https://iverilog.fandom.com/wiki/Installation_Guide#Compiling_on_MS_Windows_.28MinGW.29, which points to https://iverilog.fandom.com/wiki/Installation_using_MSYS2.

Note: If you use a MinGW shell, be aware that by default MSYS2 uses the mintty terminal emulator, which has the annoying artefact that it fully buffers all output to stdout. You can use the vvp -i option to overcome this when running simulations.

The iverilog.pdf, iverilog-vpi.pdf, and vvp.pdf files document the main commands.

@umarcor
Copy link
Contributor Author

umarcor commented Nov 29, 2020

I addressed the review comments. However, despite make check passing on both MINGW32 and MINGW64, I found that further tests segfault on MINGW64. Therefore, I opened steveicarus/iverilog#398 and I'll convert this PR to a draft until that's solved.

@umarcor umarcor marked this pull request as draft November 29, 2020 06:18
@umarcor umarcor force-pushed the iverilog branch 3 times, most recently from 8d653e6 to d1a8fd9 Compare December 5, 2020 03:31
@umarcor umarcor changed the title iverilog: add v11.0 iverilog: add v12.0.rc Dec 5, 2020
@umarcor
Copy link
Contributor Author

umarcor commented Dec 5, 2020

Maintainers of iverilog addressed the issues (including the bug that failed with ASLR). This package was thoroughly tested, by running the full test suite and arbitrary projects: https://github.com/umarcor/MINGW-packages/actions/runs/402112721. Therefore, it is ready for review.

@umarcor umarcor marked this pull request as ready for review December 5, 2020 05:36
@lazka
Copy link
Member

lazka commented Dec 6, 2020

added two commits:

  • 36198e7 (otherwise our buildbot will fail)
  • 4150eb6 (was there a reason to not use normal make?)

and merged to master in 1595e03 since I'm not allowed to push to your PR for some reason..

@lazka lazka closed this Dec 6, 2020
@umarcor
Copy link
Contributor Author

umarcor commented Dec 6, 2020

added two commits:

Nice!

(was there a reason to not use normal make?)

My ignorance. I'm not sure to know when make is acceptable and when mingw32-make is required.

and merged to master in 1595e03 since I'm not allowed to push to your PR for some reason..

That's ok. For future PRs I'll use a personal fork, instead of an org...

@umarcor umarcor deleted the iverilog branch December 6, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants