openssl: fix leak when calling relocation related functions multiple times

[lazka]

Instead of relocating every time the getters are called,
relocate only on the first call for each path.

Fixes #11552

[lazka]

This isn't thread safe, but I guess it is OK to leak one more string if there is a race (??).. otherwise we'd have to do locking somehow.

[ashie]

Thanks for the quick fix!

But it seems that memory leak still exists:

Dr. Memory version 2.5.0 build 0 built on Oct 18 2021 03:01:22
Windows version: WinVer=105;Rel=2009;Build=19044;Edition=Professional
Dr. Memory results for pid 27440: "a.exe"
Application cmdline: "a.exe"
Recorded 124 suppression(s) from default C:\Program Files (x86)\Dr. Memory\bin64\suppress-default.txt

Error #1: LEAK 121 direct bytes 0x0000028645460600-0x0000028645460679 + 0 indirect bytes
# 0 replace_malloc                             [d:\a\drmemory\drmemory\common\alloc_replace.c:2580]
# 1 libcrypto-1_1-x64.dll!simplify_path        
# 2 libcrypto-1_1-x64.dll!get_relative_path    
# 3 libcrypto-1_1-x64.dll!openssl_relocation   
# 4 libcrypto-1_1-x64.dll!X509_get_default_cert_file
# 5 libcrypto-1_1-x64.dll!by_file_ctrl         
# 6 libcrypto-1_1-x64.dll!X509_STORE_set_default_paths
# 7 main 

Error #2: LEAK 97 direct bytes 0x000002864548ef20-0x000002864548ef81 + 0 indirect bytes
# 0 replace_malloc                             [d:\a\drmemory\drmemory\common\alloc_replace.c:2580]
# 1 libcrypto-1_1-x64.dll!simplify_path        
# 2 libcrypto-1_1-x64.dll!get_relative_path    
# 3 libcrypto-1_1-x64.dll!openssl_relocation   
# 4 libcrypto-1_1-x64.dll!X509_get_default_cert_dir
# 5 libcrypto-1_1-x64.dll!dir_ctrl             
# 6 libcrypto-1_1-x64.dll!X509_STORE_set_default_paths
# 7 main 

===========================================================================
FINAL SUMMARY:

DUPLICATE ERROR COUNTS:

SUPPRESSIONS USED:

ERRORS FOUND:
      0 unique,     0 total invalid heap argument(s)
      0 unique,     0 total warning(s)
      2 unique,     2 total,    218 byte(s) of leak(s)
      0 unique,     0 total,      0 byte(s) of possible leak(s)
ERRORS IGNORED:
      1 potential leak(s) (suspected false positives)
         (details: C:\Users\aho\AppData\Roaming\Dr. Memory\DrMemory-a.exe.27440.000\potential_errors.txt)
      9 unique,     9 total,   1152 byte(s) of still-reachable allocation(s)
         (re-run with "-show_reachable" for details)

It seems that rel_to_datadir in enginedir_relocation() should be also freed.

MINGW-packages/mingw-w64-openssl/openssl-1.1.1-relocation.patch

Lines 38 to 41 in d3d5a79

	+ char * rel_to_datadir = get_relative_path (OPENSSLBIN, path);
	+ strcat (exe_path, rel_to_datadir);
	+ simplify_path (&exe_path[0]);
	+ return malloc_copy_string(exe_path);

[lazka]

ah, right, another leak.. thanks

[ashie]

@lazka I've created a patch to fix remaining leaks.
clear-code@905bb3a

Could you merge it to your pull request?
Or should I open a new pull request?

[lazka]

Sorry for the delay. I'll incorporate your changes shortly.

[ashie]

Thanks!