prjtrellis: don't force clang #10573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just curious. Was there any reason to use clang in mingw or ucrt environment where gcc is default? |
umarcor
force-pushed
the
prjtrellis-gcc
branch
from
77adf6b to
9083cbf
Compare
|
No particular reason other than IIRC the default guidelines upstream using clang. I changed the description now to use the default on each environment. I guess the issue (#10547) will remain on clang32 and clang64 only. |
umarcor
changed the title
|
the issue was in the combination of clang with BFD ld. clang+lld should be fine, and is what clang* envs use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #10547, and tested by several users, using GCC instead of clang does fix the issues with an early check introduced in mingw-w64-crt. This PR changes prjtrellis not to use clang on the default where GCC is the default.
/cc @Biswa96 @stnolting @sylefeb