niederbayern_oberpfalz: improve invalid newline detection #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klemens
requested changes
Nov 13, 2019
| @@ -61,6 +31,26 @@ | |||
| from pyopenmensa.feed import LazyBuilder | |||
|
|
|||
|
|
|||
| # Only allow a newline after 8 separators | |||
| def replace_invalid_newlines(s): | |||
There was a problem hiding this comment.
This can be fixed much simpler with the following regex, which matches one or more newlines, if they are not followed by the date pattern and semicolon (negative lookahead): \n+(?!\d\d\.\d\d\.\d\d\d\d;)
For reference, the problematic part looks like:
12.11.2019;Di;Suppe;Grießnockerlsuppe (3,A,AA,C,I);V;0,70 / 0,90 / 1,40;0,70;0,90;1,40
12.11.2019;Di;HG1;// Selbstbedienung //
Schinkennudeln (2,3,8,A,AA);S;2,00 / 2,80 / 3,60;2,00;2,80;3,60
12.11.2019;Di;HG2;Vegane Kartoffelpizza (3,F);VG;2,80 / 3,40 / 4,40;2,80;3,40;4,40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single invalid newlines weren't detected correctly. Improves fix of #107