repl: fix tab completion for a non-global context

Use vm.isContext() to properly identify contexts. PR-URL: nodejs/node-v0.x-archive#25382 PR-URL: nodejs#2052 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
mscdex · Jul 9, 2015 · 9d99dbe · 9d99dbe
1 parent 17f6d69
commit 9d99dbe
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/lib/repl.js b/lib/repl.js
@@ -611,9 +611,7 @@ REPLServer.prototype.complete = function(line, callback) {
       if (!expr) {
         // If context is instance of vm.ScriptContext
         // Get global vars synchronously
-        if (this.useGlobal ||
-            this.context.constructor &&
-            this.context.constructor.name === 'Context') {
+        if (this.useGlobal || vm.isContext(this.context)) {
           var contextProto = this.context;
           while (contextProto = Object.getPrototypeOf(contextProto)) {
             completionGroups.push(Object.getOwnPropertyNames(contextProto));

diff --git a/test/parallel/test-repl-tab-complete.js b/test/parallel/test-repl-tab-complete.js
@@ -206,3 +206,13 @@ testMe.complete('require(\'n', function(error, data) {
   assert.strictEqual(error, null);
   assert.deepEqual(data, [['net'], 'n']);
 });
+
+// Make sure tab completion works on context properties
+putIn.run(['.clear']);
+
+putIn.run([
+  'var custom = "test";'
+]);
+testMe.complete('cus', function(error, data) {
+  assert.deepEqual(data, [['custom'], 'cus']);
+});