Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROS2] Adding Initial ROS2 Launch Debug Support #368

Merged
merged 6 commits into from
Jan 12, 2021
Merged

[ROS2] Adding Initial ROS2 Launch Debug Support #368

merged 6 commits into from
Jan 12, 2021

Conversation

seanyen
Copy link

@seanyen seanyen commented Jan 11, 2021

  • Adding the initial ROS2 Launch Debug support. Current approach is to invoke ROS2 Launch System API and to mimic the entity traversal like launch_service.

@seanyen seanyen requested a review from a team as a code owner January 11, 2021 19:25
ooeygui
ooeygui approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@ooeygui ooeygui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions offline, but code looks good 👍

@seanyen seanyen merged commit 54afd4e into master Jan 12, 2021
@seanyen seanyen deleted the seanyen/ros2_launch branch January 12, 2021 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ooeygui ooeygui ooeygui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanyen @ooeygui