Examples: Add background to webgpu_pmrem_scene
#30116
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrays are not currently taken into account by the wgslTypeLib. However, with the struct extension mrdoob#29908, arrays will also become important as a type.
Update WGSLNodeBuilder.js
Since textureSampleLevel is usable in compute shaders, this small PR allows sampler to be used in compute shaders for this purpose
enables the use of samplers in compute shaders
add background to environment reflection
sunag
changed the title
webgpu_pmrem_scene
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only added a background because sunag fixed the reflection issue. Previously, when you used
fromScene, the environment was incorrectly reflected, which was not noticeable because the beckground was set to null.This couldn't be noticed with the spheres because the upside down reflection looked the same because of their color.
I actually wanted to look at the position topic as a parameter #30071 , but I don't want to make any promises that I can't keep. I am largely a user and am very busy with my projects