Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Added geometry in material cache key #29427

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Sep 16, 2024

Description

This fixes some occasions where geometry is shared with different indexes.

@sunag sunag marked this pull request as ready for review September 16, 2024 22:09
@sunag sunag added this to the r169 milestone Sep 16, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 686.07
169.79
686.07
169.79
+0 B
+0 B
WebGPU 832.67
223.1
832.7
223.11
+23 B
+8 B
WebGPU Nodes 832.18
222.98
832.21
222.99
+23 B
+8 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.42
111.53
462.42
111.53
+0 B
+0 B
WebGPU 530.14
142.82
530.17
142.83
+23 B
+8 B
WebGPU Nodes 486.8
132.68
486.82
132.69
+23 B
+6 B

@sunag sunag merged commit 5de6c61 into mrdoob:dev Sep 16, 2024
12 checks passed
@sunag sunag deleted the dev-cachekey branch September 16, 2024 22:22
@aardgoose
Copy link
Contributor

@sunag On my laptop this takes the webgpu_performance example from < 2s to display to around 13s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants