Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer: clean up #29383

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Renderer: clean up #29383

merged 1 commit into from
Sep 11, 2024

Conversation

s-rigaud
Copy link
Contributor

Small syntax improvements

Copy link

github-actions bot commented Sep 10, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.24
169.64
685.24
169.64
+0 B
+0 B
WebGPU 826.41
221.63
826.4
221.63
-6 B
+8 B
WebGPU Nodes 825.99
221.54
825.98
221.54
-6 B
+7 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.02
111.48
462.02
111.48
+0 B
+0 B
WebGPU 525.5
141.64
525.49
141.66
-6 B
+11 B
WebGPU Nodes 482.15
131.46
482.15
131.47
-6 B
+11 B

@s-rigaud s-rigaud force-pushed the small-renderer-clean-up branch from d6a2044 to 5a9fb8e Compare September 10, 2024 12:40
@Mugen87 Mugen87 added this to the r169 milestone Sep 10, 2024
@s-rigaud s-rigaud force-pushed the small-renderer-clean-up branch from 5a9fb8e to ee7931c Compare September 10, 2024 14:08
@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 10, 2024

In general the PR is okay but I hope it is not taken as an occasion to migrate all code to this style. The previous syntax is totally fine and there is no reason to move everything to destructuring.

@s-rigaud
Copy link
Contributor Author

s-rigaud commented Sep 10, 2024

I had to debug a Three project and I ended up to this file. My IDE highlited some minor changes that can be made via the sourcery plugin so I figured out I might just do a quick PR just to slightly improve the code quality, I don't expect to do more PRs like this in the future.

@sunag sunag merged commit 34bce37 into mrdoob:dev Sep 11, 2024
12 checks passed
LD2Studio pushed a commit to LD2Studio/LD2Studio-Editor that referenced this pull request Sep 13, 2024
LD2Studio pushed a commit to LD2Studio/LD2Studio-Editor that referenced this pull request Sep 13, 2024
@s-rigaud s-rigaud deleted the small-renderer-clean-up branch October 21, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants