-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renderer: clean up #29383
Renderer: clean up #29383
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
d6a2044
to
5a9fb8e
Compare
5a9fb8e
to
ee7931c
Compare
In general the PR is okay but I hope it is not taken as an occasion to migrate all code to this style. The previous syntax is totally fine and there is no reason to move everything to destructuring. |
I had to debug a Three project and I ended up to this file. My IDE highlited some minor changes that can be made via the sourcery plugin so I figured out I might just do a quick PR just to slightly improve the code quality, I don't expect to do more PRs like this in the future. |
Co-authored-by: Samuel Rigaud <[email protected]>
Co-authored-by: Samuel Rigaud <[email protected]>
Small syntax improvements