Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio: Add delay parameter to stop(). #29376

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Audio: Add delay parameter to stop(). #29376

merged 4 commits into from
Sep 11, 2024

Conversation

tatsmaki
Copy link
Contributor

@tatsmaki tatsmaki commented Sep 9, 2024 •
edited by Mugen87
Loading

Fixed #29375

Description

@tatsmaki tatsmaki changed the title feat: audio stop delay parameter Audio: stop audio with a delay Sep 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.24
169.64		 685.27
169.65		 +29 B
+8 B
WebGPU 827.95
222.1		 827.98
222.11		 +29 B
+7 B
WebGPU Nodes 827.53
222		 827.56
222.01		 +29 B
+7 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.02
111.48		 462.02
111.48		 +0 B
+0 B
WebGPU 526.16
141.85		 526.16
141.85		 +0 B
+0 B
WebGPU Nodes 482.82
131.66		 482.82
131.66		 +0 B
+0 B

@Mugen87 Mugen87 added this to the r169 milestone Sep 10, 2024
@tatsmaki tatsmaki force-pushed the feat/audio-stop-delay-param branch from b8e90aa to 1c034e5 Compare September 10, 2024 10:21
Mugen87
Mugen87 reviewed Sep 10, 2024
View reviewed changes
src/audio/Audio.js Outdated Show resolved Hide resolved
@Mugen87 Mugen87 merged commit 43dcbc1 into mrdoob:dev Sep 11, 2024
10 of 11 checks passed
@Mugen87 Mugen87 changed the title Audio: stop audio with a delay Audio: Add delay parameter to stop(). Sep 11, 2024
LD2Studio pushed a commit to LD2Studio/LD2Studio-Editor that referenced this pull request Sep 13, 2024
@tatsmaki @Mugen87 @LD2Studio
Audio: stop audio with a delay (mrdoob#29376)
25de8da 
* feat: audio stop delay parameter

* docs: audio play/stop delay parameter

* Update Audio.html

* fix: do not honor offset

---------

Co-authored-by: Michael Herzog <[email protected]>
LD2Studio pushed a commit to LD2Studio/LD2Studio-Editor that referenced this pull request Sep 13, 2024
@tatsmaki @Mugen87 @LD2Studio
Audio: stop audio with a delay (mrdoob#29376)
832ef9c 
* feat: audio stop delay parameter

* docs: audio play/stop delay parameter

* Update Audio.html

* fix: do not honor offset

---------

Co-authored-by: Michael Herzog <[email protected]>
This was referenced Sep 24, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r169
Development

Successfully merging this pull request may close these issues.

Audio AudioNode stop with delay
2 participants
@tatsmaki @Mugen87