Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons.js: Remove WebGPU modules. #29373

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Addons.js: Remove WebGPU modules. #29373

merged 1 commit into from
Sep 9, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Sep 9, 2024

Fixed #29367.

Description

The addition of WebGPU modules into Addons.js leads to unwanted side effects with bundlers since the bare module specifier three is ambiguous.

@Mugen87 Mugen87 added this to the r169 milestone Sep 9, 2024
@Mugen87 Mugen87 merged commit 5eabead into mrdoob:dev Sep 9, 2024
5 of 6 checks passed
@Mugen87 Mugen87 changed the title Addons: Remove WebGPU modules. Addons.js: Remove WebGPU modules. Sep 9, 2024
@mrdoob
Copy link
Owner

mrdoob commented Sep 12, 2024

Does this deserve a 0.168.1?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Sep 12, 2024

Probably yes. There was only one developer that complained so far. But with a patch release we avoid potential troubles for others.

@wangjiangrong
Copy link

wangjiangrong commented Sep 19, 2024

I'm from #29367, when will the new version be released?
image

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Sep 19, 2024

r169 is released next week so you eventually get a fix soon (even without 0.168.1).

@wangjiangrong
Copy link

image
There seems to be no WebGPU module in my Addon file

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Sep 23, 2024

That is the correct result actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No matching export in "node_modules/three/build/three.module.js" for import "NodeMaterial"
3 participants