New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CacheNode: Fix `parent` reference. #29369

Merged

Mugen87 merged 1 commit into mrdoob:dev from Mugen87:dev3

Sep 9, 2024

Collaborator

Mugen87 commented Sep 9, 2024

Related issue: #28950 (comment)

Description

Ensure a correct parent reference in CacheNode.build().


          CacheNode: Fix parent reference.

6f2b74e

Mugen87 added this to the r169 milestone

github-actions bot commented Sep 9, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	685.24 169.64	685.24 169.64	+0 B +0 B
WebGPU	826.38 221.62	826.38 221.62	+5 B +1 B
WebGPU Nodes	825.96 221.53	825.97 221.53	+5 B +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	462.02 111.48	462.02 111.48	+0 B +0 B
WebGPU	525.47 141.63	525.48 141.63	+5 B +1 B
WebGPU Nodes	482.13 131.44	482.13 131.44	+5 B +0 B

Mugen87 merged commit e9aebe2 into mrdoob:dev

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet