Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOD: Add removeLevel(). #29359

Merged
merged 5 commits into from
Sep 11, 2024
Merged

LOD: Add removeLevel(). #29359

merged 5 commits into from
Sep 11, 2024

Conversation

JaimeTorrealba
Copy link
Contributor

@JaimeTorrealba JaimeTorrealba commented Sep 8, 2024 •
edited
Loading

Related issue: #29074

closes #29074

Description

Add the method removeLevel to LOD class

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 8, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.42
169.7		 685.42
169.7		 +0 B
+0 B
WebGPU 828.13
222.15		 828.13
222.15		 +0 B
+0 B
WebGPU Nodes 827.71
222.05		 827.71
222.05		 +0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.02
111.48		 462.02
111.48		 +0 B
+0 B
WebGPU 526.16
141.85		 526.16
141.85		 +0 B
+0 B
WebGPU Nodes 482.82
131.66		 482.82
131.66		 +0 B
+0 B

Mugen87
Mugen87 reviewed Sep 8, 2024
View reviewed changes
src/objects/LOD.js Outdated Show resolved Hide resolved
Mugen87
Mugen87 reviewed Sep 8, 2024
View reviewed changes
src/objects/LOD.js Outdated Show resolved Hide resolved
@Mugen87 Mugen87 changed the title feat(app): 29074 Add removeLevel method for LOD LOD: Add removeLevel(). Sep 10, 2024
@Mugen87 Mugen87 added this to the r169 milestone Sep 11, 2024
@Mugen87 Mugen87 merged commit f51df38 into mrdoob:dev Sep 11, 2024
10 of 11 checks passed
LD2Studio pushed a commit to LD2Studio/LD2Studio-Editor that referenced this pull request Sep 13, 2024
@JaimeTorrealba @Mugen87 @LD2Studio
LOD: Add removeLevel(). (mrdoob#29359)
99bcea0 
* feat(app): 29074 Add removeLevel method for LOD

* fix: rename parameter

* refactor: using for loop

* refactor: apply suggestions in method structure

* Update LOD.html

---------

Co-authored-by: Michael Herzog <[email protected]>
LD2Studio pushed a commit to LD2Studio/LD2Studio-Editor that referenced this pull request Sep 13, 2024
@JaimeTorrealba @Mugen87 @LD2Studio
LOD: Add removeLevel(). (mrdoob#29359)
b57eb33 
* feat(app): 29074 Add removeLevel method for LOD

* fix: rename parameter

* refactor: using for loop

* refactor: apply suggestions in method structure

* Update LOD.html

---------

Co-authored-by: Michael Herzog <[email protected]>
This was referenced Sep 24, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Simth John-Simth John-Simth left review comments

@Mugen87 Mugen87 Mugen87 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r169
Development

Successfully merging this pull request may close these issues.

Remove level in LOD?
3 participants
@JaimeTorrealba @Mugen87 @John-Simth