TextureUtils: Add WebGPU version. #29348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Sep 7, 2024
| @@ -83,6 +83,7 @@ export function decompress( texture, maxTextureSize = Infinity, renderer = null | |||
| readableTexture.magFilter = texture.magFilter; | |||
| readableTexture.wrapS = texture.wrapS; | |||
| readableTexture.wrapT = texture.wrapT; | |||
| readableTexture.colorSpace = texture.colorSpace; | |||
There was a problem hiding this comment.
I think it's better for consistency if the color space property of the original texture is retained.
Mugen87
commented
Sep 7, 2024
| let _renderer; | ||
| const _quadMesh = /*@__PURE__*/ new QuadMesh(); | ||
|
|
||
| export async function decompress( blitTexture, maxTextureSize = Infinity, renderer = null ) { |
There was a problem hiding this comment.
The new decompress() function is now async since an internal WebGPURenderer has to call init() before performing the decompression.
Mugen87
commented
Sep 7, 2024
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29295
Description
This PR adds a WebGPU version of.
TextureUtils.