Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLRenderer: reduce ReadRenderTargetPixelsAsync latency #29339

Merged
merged 1 commit into from
Sep 6, 2024
Merged

WebGLRenderer: reduce ReadRenderTargetPixelsAsync latency #29339

merged 1 commit into from
Sep 6, 2024

Conversation

aardgoose
Copy link
Contributor

Related issue: #29335

This method is noticeably slower than the WebGL-fallback equivalent. Flushing after the gl.fenceSync resolves this.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.18
169.62		 685.18
169.62		 +0 B
+0 B
WebGPU 825.96
221.44		 825.96
221.44		 +0 B
+0 B
WebGPU Nodes 825.54
221.34		 825.54
221.34		 +0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 461.96
111.46		 461.96
111.46		 +0 B
+0 B
WebGPU 525.27
141.52		 525.27
141.52		 +0 B
+0 B
WebGPU Nodes 481.93
131.34		 481.93
131.34		 +0 B
+0 B

@Mugen87 Mugen87 added this to the r169 milestone Sep 6, 2024
@Mugen87 Mugen87 merged commit cf392ea into mrdoob:dev Sep 6, 2024
12 checks passed
@aardgoose aardgoose deleted the async branch September 6, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkjohnson gkjohnson gkjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r169
Development

Successfully merging this pull request may close these issues.
3 participants
@aardgoose @gkjohnson @Mugen87