-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addons: Remove GPUStatsPanel
.
#29317
Conversation
Does it make sense to remove this before stats-gl properly replaces stats.js? I still use this plugin and have used it to benchmark changes to some of the examples that it's removed from in this PR. |
Can you switch instead to "stats-gl": "https://cdn.jsdelivr.net/npm/[email protected]/dist/main.js" I have the feeling this is better than retaining |
I'm just suggesting to not remove stats.js related components until stats.js is removed from the project. But I see that stats-gl is basically the same thing. |
How about replacing |
Done! |
Regarding stats-gl, I’m considering disabling the GPU metrics by default. |
Released |
Related issue: #29295
Description
This PR removes the addon
GPUStatsPanel
. For more detailed performance monitoring, it's best to use https://github.com/RenaudRohlinger/stats-gl since it works for both WebGL and WebGPU.As mentioned earlier, ideally
stats-gl
replaces the originalstats.js
in the examples at some point. Since there seems to be some issues in context of Safari and M processors (see #28978), it's probably best to wait a bit until these problems have been resolved.