Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Added helpers to light probe examples #29309

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

WestLangley
Copy link
Collaborator

Added the light probe helpers to the light probe examples.

It is important to verify that:

(1) the irradiance inferred from the environment map is correct,

(2) the computed SH3 coefficients are correct, and

(3) the helper renders correctly.

Also added a notation that the light probes position property, which is important in a light probe volume, is only honored when rendering the helper. The light probe position is currently not used in the lighting calculations.

@WestLangley WestLangley added this to the r169 milestone Sep 3, 2024
@WestLangley WestLangley changed the title Examples: Added light probe helpers Examples: Added helpers to light probe examples Sep 3, 2024
@WestLangley
Copy link
Collaborator Author

How did the screen shots pass without updating them?

Also, webgl_lightprobe_cubecamera.html seems to be redundant given webgl_lightprobe.html.

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 4, 2024

Also, webgl_lightprobe_cubecamera.html seems to be redundant given webgl_lightprobe.html.

webgl_lightprobe_cubecamera covers a different use case since it generates the light probe from a render target. This code path is not yet supported in WebGPURenderer.

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 4, 2024

How did the screen shots pass without updating them?

That is indeed strange. I suggest to still regenerate the screenshot to avoid fails in future CI runs.

@WestLangley
Copy link
Collaborator Author

@Mugen87 webgpu screenshots render black for me. Is there a secret?

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 4, 2024

Have you lately executed a npm i? Maybe the dev dependencies are outdated...

@WestLangley
Copy link
Collaborator Author

I'm using homebrew... In the mean time, can you please update the webgpu screen shot?

@Mugen87 Mugen87 merged commit b304349 into mrdoob:dev Sep 4, 2024
11 checks passed
@Mugen87 Mugen87 mentioned this pull request Sep 4, 2024
@WestLangley WestLangley deleted the dev-lightprobe_examples branch September 4, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants