Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Ignore diagnostic() method in firefox #29306

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Sep 3, 2024

Related issue: #29258

Not all examples need it, so we can disable it for Firefox for as needed.

@sunag sunag added this to the r169 milestone Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.1 kB
169.6 kB
685.1 kB
169.6 kB
+0 B
+0 B
WebGPU 822.6 kB
220.8 kB
822.6 kB
220.8 kB
+78 B
+28 B
WebGPU Nodes 822.1 kB
220.7 kB
822.2 kB
220.7 kB
+497 B
+126 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 461.9 kB
111.4 kB
461.9 kB
111.4 kB
+0 B
+0 B
WebGPU 521.7 kB
140.6 kB
521.7 kB
140.7 kB
+78 B
+30 B
WebGPU Nodes 478.3 kB
130.5 kB
478.4 kB
130.5 kB
-43.27 kB
+32 B

@sunag sunag marked this pull request as ready for review September 3, 2024 16:36
@sunag sunag merged commit 841ea63 into mrdoob:dev Sep 3, 2024
12 checks passed
@sunag sunag deleted the dev-firefox branch September 3, 2024 16:38
@ErichDonGubler
Copy link

Heads up as a maintainer of Firefox's WGSL shader compiler: Once gfx-rs/wgpu#6148 lands, and it's consumed in Firefox, you should be able to revert this. You can also follow along at bug 1882800.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants