EXRExporter: Add support for WebGPURenderer.
#29302
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
|
||
| } | ||
|
|
||
| renderer.readRenderTargetPixels( rtt, 0, 0, info.width, info.height, dataBuffer ); |
There was a problem hiding this comment.
@gkjohnson My plan was to use WebGLRenderer.readRenderTargetPixelsAsync() here as well but using it produces a WebGL feedback loop warning when exporting the PMREM in misc_exporter_exr. The screen also gets black.
misc_exporter_exr.html:1 [.WebGL-0x128005ba800] GL_INVALID_OPERATION: Feedback loop formed between Framebuffer and active Texture.
I did not find the root cause so far so the WebGLRenderer code path still uses the sync approach for now. It would be great if you could provide a second pair of eyes and have a look^^.
There was a problem hiding this comment.
Do you have a minimal repro for how to cause the issue? Does it just require setting or rendering to RenderTarget A and then calling "readRenderTargetPixels"?
There was a problem hiding this comment.
Just switch to readRenderTargetPixelsAsync() in EXRExporter any try to export the PMREM in misc_exporter_exr. That should trigger the feedback loop.
Related issue: #29295
Description
To make
EXRExporterwork withWebGPURenderer, it is required to make the parse method async.Besides, the readback did not initially work as expected for both backends. In
WebGPUTextureUtilsis was required to change the typed array type toUint16Arrayfor FP16 formats.WebGLTextureUtilsrequired a fix in_getBytesPerTexel()since the method did not account for the data type so far.