Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: Fix normalView normalize() applied at vertex stage #29280

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 31, 2024

Related issue: Closes #29272

Description

Fixed difference between normalView of WebGLRenderer and WebGPURenderer.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.4 kB
169.7 kB
685.4 kB
169.7 kB
+0 B
+0 B
WebGPU 819.2 kB
221.5 kB
819.3 kB
221.5 kB
+24 B
+0 B
WebGPU Nodes 818.8 kB
221.4 kB
818.8 kB
221.4 kB
+443 B
+103 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462 kB
111.4 kB
462 kB
111.4 kB
+0 B
+0 B
WebGPU 565.4 kB
153.5 kB
565.4 kB
153.5 kB
+24 B
+0 B
WebGPU Nodes 524.7 kB
143.9 kB
524.7 kB
143.9 kB
-40.64 kB
+1 B

@sunag sunag marked this pull request as ready for review August 31, 2024 21:38
@sunag sunag merged commit ea43437 into mrdoob:dev Aug 31, 2024
12 checks passed
@sunag sunag deleted the dev-fix-normalview branch August 31, 2024 21:39
@sunag sunag added this to the r169 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alias-like artefacts in WebGL2 fallback in r168
1 participant