Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: sort bind groups and minimise setBindGroup() commands #29256

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

aardgoose
Copy link
Contributor

As title.

Copy link

github-actions bot commented Aug 29, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.4 kB
169.7 kB
685.4 kB
169.7 kB
+0 B
+0 B
WebGPU 821.7 kB
220.7 kB
822 kB
220.8 kB
+375 B
+118 B
WebGPU Nodes 821.2 kB
220.6 kB
821.6 kB
220.7 kB
+794 B
+210 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462 kB
111.4 kB
462 kB
111.4 kB
+0 B
+0 B
WebGPU 522.1 kB
140.7 kB
522.5 kB
140.8 kB
+375 B
+124 B
WebGPU Nodes 478.7 kB
130.5 kB
479.1 kB
130.6 kB
-42.98 kB
+121 B

@sunag sunag merged commit 6b74981 into mrdoob:dev Sep 2, 2024
12 checks passed
@sunag sunag added this to the r169 milestone Sep 2, 2024
@aardgoose aardgoose deleted the sort-groups branch September 9, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants